Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5662 Add linter rule for deep module imports #4538

Merged
merged 7 commits into from
Nov 10, 2023
Merged

BC-5662 Add linter rule for deep module imports #4538

merged 7 commits into from
Nov 10, 2023

Conversation

CeEv
Copy link
Contributor

@CeEv CeEv commented Nov 9, 2023

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@CeEv CeEv requested a review from SevenWaysDP November 9, 2023 08:18
@pullapprove PullApprove
Copy link

pullapprove bot commented Nov 9, 2023

Hey @CeEv, thanks for the PR! The review will start once
the tests, CI checks and PR requirements (see checklist in your PR) have passed.

@CeEv CeEv requested a review from Metauriel November 9, 2023 13:24
@CeEv CeEv enabled auto-merge (squash) November 9, 2023 15:27
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CeEv CeEv merged commit 4a7cb71 into main Nov 10, 2023
46 checks passed
@CeEv CeEv deleted the BC-5662-add-linter-rule-deep-module-imports branch November 10, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Metauriel Metauriel Metauriel approved these changes

@SevenWaysDP SevenWaysDP Awaiting requested review from SevenWaysDP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CeEv @Metauriel @SevenWaysDP